Re: [PATCH] ASoC: cs35l56: Remove NULL check from cs35l56_sdw_dai_set_stream()

[Pierre-Louis Bossart]

On 6/1/23 07:49, Richard Fitzgerald wrote:
> The dma pointer must be set to the passed stream pointer, even
> if that pointer is NULL.
> 
> Fixes: e49611252900 ("ASoC: cs35l56: Add driver for Cirrus Logic CS35L56")
> Signed-off-by: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx>

Yep, good catch, this is what we have for other codecs.

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>

> ---
>  sound/soc/codecs/cs35l56.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/sound/soc/codecs/cs35l56.c b/sound/soc/codecs/cs35l56.c
> index 3c07bd1e959e..c03f9d3c9a13 100644
> --- a/sound/soc/codecs/cs35l56.c
> +++ b/sound/soc/codecs/cs35l56.c
> @@ -704,9 +704,6 @@ static int cs35l56_sdw_dai_hw_free(struct snd_pcm_substream *substream,
>  static int cs35l56_sdw_dai_set_stream(struct snd_soc_dai *dai,
>  				      void *sdw_stream, int direction)
>  {
> -	if (!sdw_stream)
> -		return 0;
> -
>  	snd_soc_dai_dma_data_set(dai, direction, sdw_stream);
>  
>  	return 0;