Re: [PATCH] serial: core: Fix probing serial_base_bus devices
From: Greg Kroah-Hartman
Date: Thu Jun 01 2023 - 11:44:56 EST
On Thu, Jun 01, 2023 at 05:09:52PM +0200, Marek Szyprowski wrote:
> On 01.06.2023 16:21, Greg Kroah-Hartman wrote:
> > On Thu, Jun 01, 2023 at 05:14:44PM +0300, Tony Lindgren wrote:
> >> If a physical serial port device driver uses arch_initcall() we fail to
> >> probe the serial_base_bus devices and the serial port tx fails. This is
> >> because as serial_base_bus uses module_initcall().
> >>
> >> Let's fix the issue by changing serial_base_bus to use arch_initcall().
> > This will only work if the linking order is such that this will always
> > come before the drivers. Is that the case here?
>
> Yes, serial_base_bus is linked as a second object, just after the
> serial_core. Device drivers come later.
Oh good, I guess it wouldn't work at all as the serial_core is needed by
all of those drivers first too, so this should work, thanks for
checking.
greg k-h