Re: [PATCH] clk: qcom: gcc-ipq6018: remove duplicate initializers
From: Dmitry Baryshkov
Date: Thu Jun 01 2023 - 17:57:57 EST
On Fri, 2 Jun 2023 at 00:34, Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> A recent change added new initializers for .config_ctl_val and
> .config_ctl_hi_val but left the old values in place:
>
> drivers/clk/qcom/gcc-ipq6018.c:4155:27: error: initialized field overwritten [-Werror=override-init]
> 4155 | .config_ctl_val = 0x240d4828,
> | ^~~~~~~~~~
> drivers/clk/qcom/gcc-ipq6018.c:4156:30: error: initialized field overwritten [-Werror=override-init]
> 4156 | .config_ctl_hi_val = 0x6,
> | ^~~
>
> Remove the unused ones now to avoid confusion.
>
> Fixes: f4f0c8acee0e4 ("clk: qcom: gcc-ipq6018: update UBI32 PLL")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/clk/qcom/gcc-ipq6018.c | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
--
With best wishes
Dmitry