Re: [PATCH v1 26/43] pata: cirrus: add DT support for Cirrus EP93xx

From: andy . shevchenko
Date: Thu Jun 01 2023 - 21:54:49 EST


Thu, Jun 01, 2023 at 08:45:31AM +0300, Nikita Shubin kirjoitti:
> - find register range from the device tree
> - get interrupts from device tree

...

> #include <linux/ata.h>
> #include <linux/libata.h>
> #include <linux/platform_device.h>

> +#include <linux/mod_devicetable.h>

In all patches, can you try to put a new header inclusions to be ordered (to
some extent)?

> #include <linux/delay.h>
> #include <linux/dmaengine.h>
> #include <linux/ktime.h>

With the context above a new one is logically suits this location.

--
With Best Regards,
Andy Shevchenko