Re: [PATCH] gpio: ath79: Add missing check for platform_get_irq

[Jiasheng Jiang]

Thu, Jun 02, 2023 at 09:32:00 +0800, Andy Shevchenko wrote:
> Thu, Jun 01, 2023 at 04:51:32PM +0800, Jiasheng Jiang kirjoitti:
>> Add the missing check for platform_get_irq and return error
>> if it fails.
> 
>>  		girq->parents[0] = platform_get_irq(pdev, 0);
>> +		if (girq->parents[0] < 0)
>> +			return -ENODEV;
> 
> Can you elaborate why error code has to be shadowed (overriden)?

You are right.
Returning the error code is better.
I will submit a v2.
The same goes for the other patch
"gpio: sifive: Add missing check for platform_get_irq".

Thanks,
Jiasheng