RE: [PATCH v2 3/3] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 2.0/3.0 PHY

[Stanley Chang[昌育德]]

Hi Krzysztof,

> >> If these can be in the driver, why would ever they be in DTS in the first
> place?
> >>
> > Our platforms have 3 xhci controllers which map to 3 different phy ports.
> 
> You mean on the same SoC?

Yes, one SoC has three xhci controllers.

> > And the three phy ports use the same driver, but the parameters are
> different.
> > So I put the parameter settings in DTS, we have 3 usb-phy nodes representing
> 3 phy ports.
> > Also, some parameters have to be adjusted for different boards.
> > Therefore, it is more applicable in DTS than in driver.
> 
> Then it looks justified in DT, so please write proper descriptions for proper
> properties. Underscores are not allowed in node names. No fake nodes.
> Properties should usually describe physical/hardware effect not the register
> value.

I will write more detail for properties. 

> qcom,usb-snps-femto-v2.yaml is nice example. Few Mediatek bindings also
> would work.
> '

Thanks,
Stanley