Re: [PATCH 04/11] dt-bindings: stm32: add st,stm32mp25 compatibles to the stm32 family

From: Alexandre TORGUE
Date: Fri Jun 02 2023 - 08:26:41 EST


Hi Krzysztof

On 5/31/23 20:47, Krzysztof Kozlowski wrote:
On 30/05/2023 10:39, Alexandre TORGUE wrote:
Hi Conor

On 5/29/23 20:05, Conor Dooley wrote:
On Mon, May 29, 2023 at 06:20:27PM +0200, Alexandre Torgue wrote:
STM32 family is extended by the addition of the STM32MP25 SoCs. It is composed
of 4 SoCs: STM32MP251, STM32MP253, STM32MP255 and STM32MP257.

Signed-off-by: Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>

diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
index 4af5b8f4f803..7d7ca33d2e61 100644
--- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
+++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
@@ -161,6 +161,15 @@ properties:
- const: phytec,phycore-stm32mp157c-som
- const: st,stm32mp157
+ - items:
+ - const: st,stm32mp251
+ - items:
+ - const: st,stm32mp253
+ - items:
+ - const: st,stm32mp255
+ - items:
+ - const: st,stm32mp257

I assume the slightly odd format is just to avoid churn when adding
the board compatibles.

Yes, exactly.


I don't get it. How are you going to extend it? Or rather - what are you
documenting here? If these are SoCs, then this is not valid. We do not
allow these alone.

No, please drop it.

Ok. I will drop it in V2 and update binding patch which defines the STM32 EV1 board.

Thanks
Alex


Best regards,
Krzysztof