Re: [PATCH V2 01/13] dt-bindings: remoteproc: qcom: Add support for multipd model

[Manikanta Mylavarapu]

On 5/30/2023 4:16 PM, Krzysztof Kozlowski wrote:
> On 22/05/2023 00:28, Manikanta Mylavarapu wrote:
> > Add new binding document for multipd model remoteproc.
> > IPQ5018, IPQ9574 follows multipd model.
> >
> > Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@xxxxxxxxxxx>
> > ---
> > Changes in V2:
> > 	- Fixed all comments and rebased for TOT.
> > 	- Changed to BSD-3-Clause based on internal open source team
> >            suggestion.
> > 	- Added firmware-name.
> >
> >   .../bindings/remoteproc/qcom,multipd-pil.yaml | 265 ++++++++++++++++++
> >   1 file changed, 265 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml
> > new file mode 100644
> > index 000000000000..3257f27dc569
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,multipd-pil.yaml
> > @@ -0,0 +1,265 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/remoteproc/qcom,multipd-pil.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm Multipd Secure Peripheral Image Loader
> > +
> > +maintainers:
> > +  - Bjorn Andersson <andersson@xxxxxxxxxx>
> > +  - Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
> > +
> > +description:
> > +  Multipd Peripheral Image Loader loads firmware and boots Q6 pd, WCSS pd
> > +  remoteproc's on the Qualcomm IPQ5018, IPQ9574 SoC. Pd means protection
> > +  domain. It's similar to process in Linux. Here QDSP6 processor runs each
> > +  wifi radio functionality on a separate process. One process can't access
> > +  other process resources, so this is termed as PD i.e protection domain.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - qcom,ipq5018-q6-mpd
> > +      - qcom,ipq9574-q6-mpd
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  firmware-name:
> > +    $ref: /schemas/types.yaml#/definitions/string-array
> > +    description: Firmware name of the Hexagon core
> > +
> > +  interrupts-extended:
> > +    items:
> > +      - description: Watchdog interrupt
> > +      - description: Fatal interrupt
> > +      - description: Ready interrupt
> > +      - description: Handover interrupt
> > +      - description: Stop acknowledge interrupt
>
>
> interrupts instead. The same in required:. I replied also to your
> comment on your comment. :)
>
> Best regards,
> Krzysztof

I will use interrupts instead of interrupts-extended in dt-bindings.

Thanks & Regards,
Manikanta.