Re: [PATCH] selftests: allow runners to override the timeout

[Shuah Khan]

On 5/24/23 16:58, Luis Chamberlain wrote:
> On Thu, May 11, 2023 at 08:26:42AM -0700, Luis Chamberlain wrote:
> > On Fri, Apr 28, 2023 at 1:34 AM Muhammad Usama Anjum
> > <usama.anjum@xxxxxxxxxxxxx> wrote:
> > > On 4/15/23 12:38 AM, Luis Chamberlain wrote:
> > > > The default timeout for selftests tests is 45 seconds. Although
> > > > we already have 13 settings for tests of about 96 sefltests which
> > > > use a timeout greater than this, we want to try to avoid encouraging
> > > > more tests to forcing a higher test timeout as selftests strives to
> > > > run all tests quickly. Selftests also uses the timeout as a non-fatal
> > > > error. Only tests runners which have control over a system would know
> > > > if to treat a timeout as fatal or not.
> > > >
> > > > To help with all this:
> > > >
> > > >    o Enhance documentation to avoid future increases of insane timeouts
> > > >    o Add the option to allow overriding the default timeout with test
> > > >      runners with a command line option
> > > >
> > > > Suggested-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
> > > > Signed-off-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>
> > > Reviewed-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
> > > Tested-by:Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
> >
> > Shuah, just a friendly poke! This is needed to allow me to enable full
> > automation for kdevops for selftests.
>
> Shuah, friendly re-poke.
>
>    Luis

Thanks. I will apply this for next.

thanks,
-- Shuah