Re: [PATCH v6 09/21] timer: add_timer_on(): Make sure TIMER_PINNED flag is set

[Frederic Weisbecker]

Le Wed, May 10, 2023 at 09:28:05AM +0200, Anna-Maria Behnsen a écrit :
> When adding a timer to the timer wheel using add_timer_on(), it is an
> implicitly pinned timer. With the timer pull at expiry time model in place,
> TIMER_PINNED flag is required to make sure timers end up in proper base.
> 
> Add TIMER_PINNED flag unconditionally when add_timer_on() is executed.
> 
> Signed-off-by: Anna-Maria Behnsen <anna-maria@xxxxxxxxxxxxx>

The current users of add_timer_on() don't seem to play nasty
games. Those who use mixes of add_timer_on() and mod_timer()
at least have set TIMER_PINNED on setup time, so looks good.

Reviewed-by: Frederic Weisbecker <frederic@xxxxxxxxxx>