Re: [PATCH v2 2/3] dt-bindings: display: panel: add fannal,c3004

From: Krzysztof Kozlowski
Date: Tue Jun 06 2023 - 03:10:29 EST


On 05/06/2023 17:35, Paulo Pavacic wrote:
> Added fannal to vendor-prefixes and dt bindings for Fannal C3004.
> Fannal C3004 is a 480x800 MIPI DSI Panel which requires
> DCS initialization sequences with certain delays between certain
> commands.


> + #include <dt-bindings/gpio/gpio.h>
> + dsi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + panel@0 {
> + compatible = "fannal,c3004";
> + reg = <0>;
> + pinctrl-0 = <&pinctrl_mipi_dsi_rst>;
> + pinctrl-names = "default";
> + reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
> + vdd-supply = <&reg1>;
> + vddio-supply = <&reg2>;
> + width-mm = <93>;
> + height-mm = <56>;
> + panel-timing {
> + clock-frequency = <27000000>;
> + hactive = <480>;
> + vactive = <800>;
> + hfront-porch = <30>;
> + hback-porch = <30>;
> + hsync-len = <8>;
> + vback-porch = <30>;
> + vfront-porch = <30>;
> + vsync-len = <8>;
> + };
> + };
> + };


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5c22c828ab46..62374c8424b9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6427,6 +6427,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc
> F: Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml
> F: drivers/gpu/drm/panel/panel-ebbg-ft8719.c
>
> +DRM DRIVER FOR FANNAL C3004373132019A
> +M: Paulo Pavacic <pavacic.p@xxxxxxxxx>
> +S: Maintained
> +C: matrix:r/mipi-dsi-bringup:matrix.org

I don't think we have chat channels for individual, small drivers. Add a
channel for entire subsystem.

Best regards,
Krzysztof