Re: arm: shmobile_defconfig: ld.lld: error: undefined symbol: lynx_pcs_destroy

[Geert Uytterhoeven]

Hi Arnd,

On Tue, Jun 6, 2023 at 11:16 AM Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Tue, Jun 6, 2023, at 11:01, Geert Uytterhoeven wrote:
> > On Tue, Jun 6, 2023 at 10:53 AM Naresh Kamboju
> > <naresh.kamboju@xxxxxxxxxx> wrote:
> >> On Tue, 6 Jun 2023 at 14:17, Naresh Kamboju <naresh.kamboju@xxxxxxxxxx> wrote:
> >> > Following build regressions found while building arm shmobile_defconfig on
> >> > Linux next-20230606.
> >> >
> >> > Regressions found on arm:
> >> >
> >> >  - build/clang-16-shmobile_defconfig
> >> >  - build/gcc-8-shmobile_defconfig
> >> >  - build/gcc-12-shmobile_defconfig
> >> >  - build/clang-nightly-shmobile_defconfig
> >>
> >> And mips defconfig builds failed.
> >> Regressions found on mips:
> >>
> >>   - build/clang-16-defconfig
> >>   - build/gcc-12-defconfig
> >>   - build/gcc-8-defconfig
> >>   - build/clang-nightly-defconfig
> >
> > Please give my fix a try:
> > https://lore.kernel.org/linux-renesas-soc/7b36ac43778b41831debd5c30b5b37d268512195.1686039915.git.geert+renesas@xxxxxxxxx
>
> This won't work when PCS_LYNX is a loadable module and
> STMMAC is built-in. I think we should just select PCS_LYNX

Oops, you're right, forgot about that case.
What about using IS_REACHABLE() instead?
No, that won't work either, as DWMAC_SOCFPGA can be modular,
with STMMAC builtin.

> unconditionally from stmmac even if no front-end driver
> using it is enabled.
>
> I tried to come up with a way to move the dependency into
> the altera specific front-end, but couldn't find an obvious
> or simple way to do this.
>
> Having a proper abstraction for PCS drivers instead of
> directly calling into exported driver symbols might help
> here, but that would add complexity elsewhere.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds