Re: [PATCH v2 1/1] test_firmware: return ENOMEM instead of ENOSPC on failed memory allocation

[Mirsad Todorovac]

On 6/6/23 09:14, Dan Carpenter wrote:
> On Tue, Jun 06, 2023 at 09:08:10AM +0200, Mirsad Goran Todorovac wrote:
> > In a couple of situations like
> >
> > 	name = kstrndup(buf, count, GFP_KERNEL);
> > 	if (!name)
> > 		return -ENOSPC;
> >
> > the error is not actually "No space left on device", but "Out of memory".
> >
> > It is semantically correct to return -ENOMEM in all failed kstrndup()
> > and kzalloc() cases in this driver, as it is not a problem with disk
> > space, but with kernel memory allocator failing allocation.
> >
> > The semantically correct should be:
> >
> >          name = kstrndup(buf, count, GFP_KERNEL);
> >          if (!name)
> >                  return -ENOMEM;
> >
> > Cc: Dan Carpenter <error27@xxxxxxxxx>
> > Cc: Takashi Iwai <tiwai@xxxxxxx>
> > Cc: Kees Cook <keescook@xxxxxxxxxxxx>
> > Cc: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxxxxxxxxxx>
> > Cc: Scott Branden <sbranden@xxxxxxxxxxxx>
> > Cc: Hans de Goede <hdegoede@xxxxxxxxxx>
> > Cc: Brian Norris <briannorris@xxxxxxxxxxxx>
> > Fixes: c92316bf8e948 ("test_firmware: add batched firmware tests")
> > Fixes: 0a8adf584759c ("test: add firmware_class loader test")
> > Fixes: 548193cba2a7d ("test_firmware: add support for firmware_request_platform")
> > Fixes: eb910947c82f9 ("test: firmware_class: add asynchronous request trigger")
> > Fixes: 061132d2b9c95 ("test_firmware: add test custom fallback trigger")
> > Fixes: 7feebfa487b92 ("test_firmware: add support for request_firmware_into_buf")
> > Signed-off-by: Mirsad Goran Todorovac <mirsad.todorovac@xxxxxxxxxxxx>
> > ---
>
> Thanks!

Thank you for reviewing the patch at such a short notice.
Though it is merely a code consistency fix.

Best regards,
Mirsad Todorovac

> Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> regards,
> dan carpenter

--
Mirsad Goran Todorovac
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu

System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb, Republic of Croatia