Re: [PATCH v2] overlayfs: clean error handling

[Miklos Szeredi]

On Sat, 6 May 2023 at 17:09, wenjun93 <gwj0511@xxxxxxxxx> wrote:
>
> Remove PTR_ERR from unused code path and
> assign error value where it exactly happens.
> This cleans the code and also helps to reduce
> the possibility of incorrect err settings
> when it's set globally and is forgotten to be
> overwrite in custom development.
>
> Signed-off-by: wenjun93 <gwj1235@xxxxxxxx>

Nack.

This is a regularly used pattern across the kernel to unclutter error handling.

If you find a concrete bug, please submit a fix for that.

Thanks,
Miklos