Re: [PATCH v8 3/3] dt-bindings: mtd: marvell-nand: Convert to YAML DT scheme

From: Krzysztof Kozlowski
Date: Tue Jun 06 2023 - 07:10:05 EST


On 06/06/2023 12:57, Miquel Raynal wrote:
>
>>
>> Now for actual paragraph:
>>
>> "If yes, then it means we would need to list *all* the nand chip
>> properties in each schema,"
>>
>> No, why? I don't understand. Use the same pattern as all other bindings,
>> this is not special. Absolutely all have the same behavior, e.g.
>> mentioned leds. You finish with unevaluatedProps and you're done, which
>> is what I wrote here long, long time ago.
>
> Maybe because so far we did not bother referencing another schema in
> the NAND chip nodes? For your hint to work I guess we should have, in
> each controller binding, something along:
>
> patternProperties:
> "^nand@[a-f0-9]$":
> type: object
> + $ref: nand-chip.yaml#
> properties:
>
> If yes, please ignore the series sent aside, I will work on it again
> and send a v2.

nand-controller.yaml has it, so ideally each device binding should not
need it, because it already references nand-controller.yaml. However if
it doesn't work, then you need nand-chip in each device binding.

Best regards,
Krzysztof