RE: [PATCH v1] make AUXILIARY_BUS config selection clearer

[Moti Haimovski]

> -----Original Message-----
> From: Conor Dooley <conor@xxxxxxxxxx>
> Sent: Tuesday, 6 June 2023 18:05
> To: Moti Haimovski <mhaimovski@xxxxxxxxx>
> Cc: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>;
> gregkh@xxxxxxxxxxxxxxxxxxx; david.m.ertman@xxxxxxxxx;
> ogabbay@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v1] make AUXILIARY_BUS config selection clearer
> 
> On Tue, Jun 06, 2023 at 02:50:21PM +0000, Moti Haimovski wrote:
> > > From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> On Tue, Jun 06,
> 2023
> > > at 04:35:28PM +0300, Moti Haimovski wrote:
> > > > Add a display string and a help section to the config
> > > > AUXILIARY_BUS section under the "Generic Driver Options" menu in
> > > > order to make its selection clearer.
> > >
> > > I am a wee bit confused, since it is not explicitly mentioned here,
> > > why is this now going to be user visible/selectable? What was wrong
> > > with the drivers that needed it selecting it?
> 
> (please don't top post)
> 
> >  Noting is wrong with the drivers 😊
> >
> > I've stumbled that issue when trying to figure-out how to manipulate
> > the auxiliary-bus selection Via "make menuconfig"
> > The issue is that with the current Kconfig when you run " make
> menuconfig" and enter the
> > Device Drivers --->     Generic Driver Options --->   Sub-menu then there is
> no mentioning of
> >  the Auxiliary bus although it is the first entry in drivers/base/Kconfig that
> this menu is presenting.
> > So, the user has no idea that this option exists and no way to manipulate it
> via menconfig.
> 
> That's the point of how it currently is though, no?
> We don't allow users to set the option, but rather any device driver that
> needs it, selects it.
> That way, a person configuring their kernel for some hardware just needs to
> enable the drivers for their hardware and knowledge of kernel internals is
> not needed.
> 
> Is there a particular driver, perhaps in drivers/accel, that does not select the
> option, which is why you are trying to set it yourself?

No, nothing specific. Just saw it and thought it is an issue to address, 
sent a private mail to the author (Dave Ertman <david.m.ertman@xxxxxxxxx>)
Who replied that he was unaware that it was a naked bool in the base/Kconfig file!
And there is no reason that he is aware of for it to be that way.
So, I've added it.

> 
> Cheers,
> Conor.
> 
> > My commit makes this option "visible" by adding the short description
> > in the "bool" line and , while at it, adding a short description for the sake of
> future generations.
> > No functionality nor default values were altered.
> 
> > > >
> > > > Signed-off-by: Moti Haimovski <mhaimovski@xxxxxxxxx>
> > > > ---
> > > >  drivers/base/Kconfig | 11 ++++++++++-
> > > >  1 file changed, 10 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig index
> > > > 6f04b831a5c0..e1caac1d9a58 100644
> > > > --- a/drivers/base/Kconfig
> > > > +++ b/drivers/base/Kconfig
> > > > @@ -2,7 +2,16 @@
> > > >  menu "Generic Driver Options"
> > > >
> > > >  config AUXILIARY_BUS
> > > > -	bool
> > > > +	bool "Support for auxiliary bus"
> > > > +	help
> > > > +	  The auxiliary bus driver provides a way to export an interface
> > > > +	  for another subsystem to drive, implement a common intersection
> > > > +	  of functionality or split a function into child-devices
> > > > +	  representing sub-domains of functionality where each auxiliary
> > > > +	  device represents a part of its parent functionality (usually)
> > > > +	  driven by another driver.
> > > > +
> > > > +	  If unsure, say Y.
> > > >
> > > >  config UEVENT_HELPER
> > > >  	bool "Support for uevent helper"
> > > > --
> > > > 2.25.1
> > > >