Re: [PATCH v4 1/4] Input: ads7846 - Convert to use software nodes

[Linus Walleij]

On Sun, Jun 4, 2023 at 5:44 PM Christophe JAILLET
<christophe.jaillet@xxxxxxxxxx> wrote:

> > +     /* Asserts RESET */
> > +     gpiod_set_value(md->reset, 1);
>
> Hi,
>
> should this also be done in the probe if mipid_detect() fails?

It's a nice bonus but surely not urgent or necessary.

> If yes, please also look at [1], that I've just sent, which introduces
> an error handling path in the probe.

Looks good to me.
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij