Re: [PATCH 2/2] xen-blkback: Inform userspace that device has been opened

From: Christoph Hellwig
Date: Wed Jun 07 2023 - 03:48:09 EST


> --- a/drivers/block/xen-blkback/xenbus.c
> +++ b/drivers/block/xen-blkback/xenbus.c
> @@ -3,6 +3,20 @@
> Copyright (C) 2005 Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> Copyright (C) 2005 XenSource Ltd
>
> +In addition to the Xenstore nodes required by the Xen block device
> +specification, this implementation of blkback uses a new Xenstore
> +node: "opened". blkback sets "opened" to "0" before the hotplug script
> +is called. Once the device node has been opened, blkback sets "opened"
> +to "1".

This is a really odd comment style, and a really strange place for it.
To me it feels like this should just be a file in Documentation as it
relates to how to use the driver, and doesn't really explain the code.