Re: [PATCH] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO

[Paul Cercueil]

Hi Sui,

Le mercredi 07 juin 2023 à 15:22 +0800, Sui Jingfeng a écrit :
> Otherwise its failed to pass basic compile test on platform without
> REGMAP_MMIO selected by defconfig
> 
> make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
> 
>   SYNC    include/config/auto.conf.cmd
>   Checking missing-syscalls for N32
>   CALL    scripts/checksyscalls.sh
>   Checking missing-syscalls for O32
>   CALL    scripts/checksyscalls.sh
>   CALL    scripts/checksyscalls.sh
>   MODPOST Module.symvers
> ERROR: modpost: "__devm_regmap_init_mmio_clk"
> [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
> make: *** [Makefile:1978: modpost] Error 2
> 
> Signed-off-by: Sui Jingfeng <suijingfeng@xxxxxxxxxxx>
> ---
>  drivers/gpu/drm/ingenic/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/ingenic/Kconfig
> b/drivers/gpu/drm/ingenic/Kconfig
> index a53f475d33df..7457c0b65034 100644
> --- a/drivers/gpu/drm/ingenic/Kconfig
> +++ b/drivers/gpu/drm/ingenic/Kconfig
> @@ -5,6 +5,8 @@ config DRM_INGENIC
>         depends on CMA
>         depends on OF
>         depends on COMMON_CLK
> +       select REGMAP
> +       select REGMAP_MMIO

nit: order alphabetically (move them after the DRM_* ones).

Cheers,
-Paul

>         select DRM_BRIDGE
>         select DRM_PANEL_BRIDGE
>         select DRM_KMS_HELPER