Re: [PATCH] streamline_config.pl: handle also ${CONFIG_FOO}

From: Steven Rostedt
Date: Wed Jun 07 2023 - 10:50:11 EST


On Wed, 7 Jun 2023 21:22:47 +0900
Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:

> On Wed, Jun 7, 2023 at 3:14 PM Jiri Slaby (SUSE) <jirislaby@xxxxxxxxxx> wrote:
> >
> > From: Jiri Slaby <jslaby@xxxxxxx>
> >
> > streamline_config.pl currently searches for CONFIG options in Kconfig
> > files as $(CONFIG_FOO). But some Kconfigs (e.g. thunderbolt) use
> > ${CONFIG_FOO}. So fix up the regex to accept both.
> >
> > This fixes:
> > $ make LSMOD=`pwd/`/lsmod localmodconfig
> > using config: '.config'
> > thunderbolt config not found!!
> >
> > Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> > Cc: andreas.noever@xxxxxxxxx
> > Cc: michael.jamet@xxxxxxxxx
> > Cc: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> > Cc: YehezkelShB@xxxxxxxxx
> > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > Cc: Linux Kbuild mailing list <linux-kbuild@xxxxxxxxxxxxxxx>
> > ---

I believe I acked this change back here:

https://lore.kernel.org/all/20230513192821.34ca93fd@xxxxxxxxxxxxxxxxxxxx/

But again:

Acked-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>

-- Steve