Re: [PATCH v2 3/3] ufs: poll pmc until another pa request is completed

[Bart Van Assche]

On 6/4/23 18:15, Kiwoong Kim wrote:
> v2 -> v3
> 1) check time in the loop with jiffies, instead of miliseconds.
> 2) change a variable's name and fix a typo and wrong alignment.
>
> v1 -> v2
> 1) remove clearing hba->active_uic_cmd at the end of __ufshcd_poll_uic_pwr
> 2) change commit message on the cited clause: 5.7.12.11 -> 5.7.12.1.1
> 3) add mdelay to avoid too many issueing
> 4) change the timeout for the polling to 100ms because I found it
> sometimes takes much longer than expected.

A change history like the above should either occur below the "---" 
separator or in a cover letter instead of in the patch description.

> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
[ ... ]

There are two changes in this patch: the introduction of the 
__ufshcd_poll_uic_pwr() helper function and also the introduction of a 
wait loop. Please split this patch into two patches - one patch that 
introduces the helper function and a second patch that introduces the 
wait loop. That will make this patch series easier to review.

Thanks,

Bart.