Re: [PATCH v4 2/3] media: dt-bindings: alvium: add document YAML binding

[Tommaso Merciai]

On Wed, Jun 07, 2023 at 06:11:54PM +0200, Krzysztof Kozlowski wrote:
> On 07/06/2023 17:20, Tommaso Merciai wrote:
> > Hi Krzysztof,
> > 
> > On Wed, Jun 07, 2023 at 04:18:48PM +0200, Krzysztof Kozlowski wrote:
> >> On 07/06/2023 15:19, Tommaso Merciai wrote:
> >>> Add documentation of device tree in YAML schema for the ALVIUM
> >>> Camera from Allied Vision Inc.
> >>>
> >>> References:
> >>>  - https://www.alliedvision.com/en/products/embedded-vision-solutions
> >>>
> >>> Signed-off-by: Tommaso Merciai <tomm.merciai@xxxxxxxxx>
> >>> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> >>> ---
> >>> Changes since v1:
> >>>  - Fixed build error as suggested by RHerring bot
> >>>
> >>> Changes since v2:
> >>>  - Fixed License as suggested by KKozlowski/CDooley
> >>>  - Removed rotation property as suggested by CDooley/LPinchart
> >>>  - Fixed example node name as suggested by CDooley
> >>>  - Fixed title as suggested by LPinchart
> >>>  - Fixed compatible name as suggested by LPinchart
> >>>  - Removed clock as suggested by LPinchart
> >>>  - Removed gpios not as suggested by LPinchart
> >>>  - Renamed property name streamon-delay into alliedvision,lp2hs-delay-us
> >>>  - Fixed vendor prefix, unit append as suggested by KKozlowski
> >>>  - Fixed data-lanes
> >>>  - Fixed blank space + example indentation (from 6 -> 4 space) as suggested by KKozlowski
> >>>  - Dropped status into example  as suggested by KKozlowski
> >>>  - Added vcc-ext-in supply as suggested by LPinchart
> >>>  - Dropped pinctrl into example as suggested by LPinchart
> >>>
> >>> Changes since v3:
> >>>  - Fixed vcc-ext-in-supply description as suggested by LPinchart
> >>>  - Fixed alliedvision,lp2hs-delay-us description as suggested by LPinchart
> >>>  - Added maximum to alliedvision,lp2hs-delay-us as suggested by LPinchart
> >>>  - Collected Reviewed-by tag from LPinchart
> >>
> >> You still did not test it before sending. Four versions of which none
> >> were tested :(
> > 
> > You are right.. my bad. :'(
> > 
> > After fixing id, as suggested by Laurent/bot into:
> > 
> > $id: http://devicetree.org/schemas/media/i2c/alliedvision,alvium-csi2.yaml#
> > 
> > I'm running the following test:
> > 
> > make dt_binding_check DT_SCHEMA_FILES=alliedvision,alvium-csi2.yaml
> > 
> > With the following result:
> > 
> >   LINT    Documentation/devicetree/bindings
> >   CHKDT   Documentation/devicetree/bindings/processed-schema.json
> >   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
> > /home/tom/work/mainline/linux/Documentation/devicetree/bindings/media/i2c/.alliedvision,alvium-csi2.example.dts.pre.yaml: ignoring, error parsing file
> >   DTEX    Documentation/devicetree/bindings/media/i2c/alliedvision,alvium-csi2.example.dts
> >   DTC_CHK Documentation/devicetree/bindings/media/i2c/alliedvision,alvium-csi2.example.dtb
> > 
> > Is that correct?
> 
> No, it doesn't look correct. You have error parsing your file. Check
> your yaml file and its example DTSI.
> 
> Be sure you have also yamlling installed.

Thanks for the feedback!

Regards,
Tommaso

> 
> Best regards,
> Krzysztof
>