Re: [PATCH 7/7] watchdog/hardlockup: Define HARDLOCKUP_DETECTOR_ARCH

From: Doug Anderson
Date: Wed Jun 07 2023 - 19:37:52 EST


Hi,

On Wed, Jun 7, 2023 at 8:26 AM Petr Mladek <pmladek@xxxxxxxx> wrote:
>
> @@ -1102,6 +1103,14 @@ config HARDLOCKUP_DETECTOR_BUDDY
> depends on !HAVE_HARDLOCKUP_DETECTOR_ARCH
> select HARDLOCKUP_DETECTOR_COUNTS_HRTIMER
>
> +config HARDLOCKUP_DETECTOR_ARCH
> + bool
> + depends on HARDLOCKUP_DETECTOR
> + depends on HAVE_HARDLOCKUP_DETECTOR_ARCH
> + help
> + The arch-specific implementation of the hardlockup detector is
> + available.

nit: "is available" makes it sound a bit too much like a "have"
version. Maybe "The arch-specific implementation of the hardlockup
detector will be used" or something like that?

Otherise:

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>