Re: [PATCH v4 3/8] drm/mediatek: extract common functions from the mtk hdmi driver

[CK Hu (胡俊光)]

Hi, Guillaume:

On Mon, 2023-05-29 at 16:31 +0200, Guillaume Ranquet wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  Create a common "framework" that can be used to add support for
> different hdmi IPs within the mediatek range of products.
> 
> Signed-off-by: Guillaume Ranquet <granquet@xxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/mediatek/Makefile          |   3 +-
>  drivers/gpu/drm/mediatek/mtk_hdmi.c        | 596 ++-----------------
> ----------
>  drivers/gpu/drm/mediatek/mtk_hdmi.h        |  18 +
>  drivers/gpu/drm/mediatek/mtk_hdmi_common.c | 407
> ++++++++++++++++++++
>  drivers/gpu/drm/mediatek/mtk_hdmi_common.h | 207 ++++++++++
>  5 files changed, 666 insertions(+), 565 deletions(-)
> 
> 

I would like the file naming as:

mtk_hdmi.c => mtk_hdmi_mt8173.c
mtk_hdmi.h => mtk_hdmi_mt8173.h
mtk_hdmi_common.c => mtk_hdmi.c
mtk_hdmi_common.h => mtk_hdmi.h

and your v2 file naming as:

mtk_hdmi_mt8195.c
mtk_hdmi_mt8195.h

Regards,
CK