Re: [PATCH v4 3/3] drm/panel-fannal-c3004: Add fannal c3004 DSI panel

[Paulo Pavacic]

pet, 16. lip 2023. u 13:44 Linus Walleij <linus.walleij@xxxxxxxxxx> napisao je:
>
> On Fri, Jun 16, 2023 at 11:57 AM Paulo Pavacic <pavacic.p@xxxxxxxxx> wrote:
> > čet, 15. lip 2023. u 21:55 Linus Walleij <linus.walleij@xxxxxxxxxx> napisao je:
> > >
> > > I doubt that the display controller is actually by Fannal, but I guess
> > > you tried to find out? We usually try to identify the underlying display
> > > controller so the driver can be named after it and reused for more
> > > display panels.
> >
> > Yes, of course, the controller is ST7701S.
>
> Hm did you try to just refactor
> drivers/gpu/drm/panel/panel-sitronix-st7701.c
> to support your new panel?
>

Yes I have tried, but there are too many changes needed and I wasn't
sure whether I would be breaking compatibility with st7701 based
panels.

> One major reason would be that that driver knows what
> commands actually mean and have #defines for them.
>
> Yours,
> Linus Walleij

Best regards,
Paulo