RE: [PATCH net-next 0/6] igc: Fix corner cases for TSN offload

[Zulkifli, Muhammad Husaini]

> -----Original Message-----
> From: Florian Kauer <florian.kauer@xxxxxxxxxxxxx>
> Sent: Saturday, 17 June, 2023 12:11 AM
> To: Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli@xxxxxxxxx>;
> Brandeburg, Jesse <jesse.brandeburg@xxxxxxxxx>; Nguyen, Anthony L
> <anthony.l.nguyen@xxxxxxxxx>; Gomes, Vinicius <vinicius.gomes@xxxxxxxxx>;
> David S . Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet
> <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni
> <pabeni@xxxxxxxxxx>; Tan Tee Min <tee.min.tan@xxxxxxxxxxxxxxx>;
> Gunasekaran, Aravindhan <aravindhan.gunasekaran@xxxxxxxxx>; Chilakala,
> Mallikarjuna <mallikarjuna.chilakala@xxxxxxxxx>
> Cc: intel-wired-lan@xxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; kurt@xxxxxxxxxxxxx
> Subject: Re: [PATCH net-next 0/6] igc: Fix corner cases for TSN offload
> 
> On 16.06.23 17:53, Zulkifli, Muhammad Husaini wrote:
> >> Florian Kauer (6):
> >>   igc: Rename qbv_enable to taprio_offload_enable
> >>   igc: Do not enable taprio offload for invalid arguments
> >>   igc: Handle already enabled taprio offload for basetime 0
> >>   igc: No strict mode in pure launchtime/CBS offload
> >>   igc: Fix launchtime before start of cycle
> >>   igc: Fix inserting of empty frame for launchtime
> >
> > All six patches, as far as I can see here, have the Fixes tag. Should they go to
> Net instead of Net-Next?
> 
> You are correct, these are all fixes and could go to net.
> However, in its current form they will not fully apply to net (e.g. due to the
> commit 2d800bc500fb ("net/sched: taprio: replace tc_taprio_qopt_offload ::
> enable with a "cmd" enum") that has overlapping code changes) and are also
> not tested with net.
> If you prefer to have them in net already I could send a second series.
> For me personally all options (net, net-next or iwl-next) would be fine.

Yeah I would prefer "net" so that it can be available in current development kernel.
"Net-next" will take sometimes to go in....
Looks like only patch no 2 "igc: Do not enable taprio offload for invalid arguments"
will have conflict due to the new "cmd" command introduced by vlamidir. 
But I think should be minor changes.

Thanks

> 
> Thanks,
> Florian