Re: [PATCH v6 18/22] clk: qcom: smd-rpm: Separate out interconnect bus clocks

From: Stephen Boyd
Date: Fri Jun 16 2023 - 16:28:02 EST


Quoting Konrad Dybcio (2023-06-15 00:49:59)
> On 15.06.2023 02:48, Stephen Boyd wrote:
> > Quoting Konrad Dybcio (2023-06-14 11:04:37)
> >> @@ -1332,6 +1275,15 @@ static int rpm_smd_clk_probe(struct platform_device *pdev)
> >> goto err;
> >> }
> >>
> >> + for (i = 0; i < desc->num_icc_clks; i++) {
> >> + if (!desc->icc_clks[i])
> >> + continue;
> >> +
> >> + ret = clk_smd_rpm_handoff(desc->icc_clks[i]);
> >
> > This API can probably take a const struct clk_smd_rpm pointer as well.
> It would be great, but ideally we want to set r->enabled in that func
> for !bus clocks (for unused clk cleanup). I could probably introduce a
> separate function for the icc clocks that takes const.
>

Sure. Or have this take const and in the clk driver set r->enabled after
calling it. That's future code though, so just make it take const?