Re: [PATCH v3 2/9] clk: ralink: add clock and reset driver for MTMIPS SoCs

[Sergio Paracuellos]

Hi Shiji Yang!

On Sat, Jun 17, 2023 at 6:51 AM <yangshiji66@xxxxxxxxxxx> wrote:
>
> Thank you for taking care of these old amazing SoCs. When I ported these
> patches to OpenWrt, I found some issues.

Thanks for testing this!

>
> >+
> >+static const struct of_device_id mtmips_of_match[] = {
> >+      {
> >+              .compatible = "ralink,rt2880-sysc",
> >+              .data = &rt2880_clk_data,
> >+      },
> >+      {
> >+              .compatible = "ralink,rt3050-sysc",
> >+              .data = &rt3050_clk_data,
> >+      },
> >+      {
> >+              .compatible = "ralink,rt3052-sysc",
> >+              .data = &rt3052_clk_data,
> >+      },
> >+      {
> >+              .compatible = "ralink,rt3352-sysc",
> >+              .data = &rt3052_clk_data,
>
> It seems that there should be `.data = &rt3352_clk_data,`?

Good catch! Thanks!
>
> >+      },
> >+      {
> >+              .compatible = "ralink,rt3883-sysc",
> >+              .data = &rt3352_clk_data,
> >+      },
>
> And there should be `.data = &rt3883_clk_data,`?

True.

>
> >+      {
> >+              .compatible = "ralink,rt5350-sysc",
> >+              .data = &rt5350_clk_data,
> >+      },
> >+      {
> >+              .compatible = "ralink,mt7620a-sysc",
> >+              .data = &mt7620_clk_data,
> >+      },
> >+      {
> >+              .compatible = "ralink,mt7620-sysc",
> >+              .data = &mt7620_clk_data,
> >+      },
> >+      {
>
> I am confused about the difference between `ralink,mt7620-sysc` and
> `ralink,mt7620a-sysc`. Do you mean mt7620n?
> https://www.mediatek.com/products/home-networking/mt7620n-a

There is no real difference. As you can see both of them use the same
'mt7620_clk_data' but since both compatible strings already exist
somewhere I introduced both of them.

>
> >+              .compatible = "ralink,mt7628-sysc",
> >+              .data = &mt76x8_clk_data,
> >+      },
> >+      {
> >+              .compatible = "ralink,mt7688-sysc",
> >+              .data = &mt76x8_clk_data,
> >+      },
> >+      {}
> >+};
> >+
>
> Thanks,
>     Shiji Yang

Thomas, I am going to send v4 with all Reviewed-by and Acked-by tags
added as well as this two minor stuff fixed.

Thanks,
    Sergio Paracuellos