Re: [PATCH 1/2] dt-bindings: leds: Add Kinetic KTD2026/2027 LED

From: Krzysztof Kozlowski
Date: Sun Jun 18 2023 - 08:42:04 EST


On 18/06/2023 13:45, André Apitzsch wrote:
> Document Kinetic KTD2026/2027 LED driver devicetree bindings.
>
> Signed-off-by: André Apitzsch <git@xxxxxxxxxxx>
> ---
> .../devicetree/bindings/leds/leds-ktd202x.yaml | 164 +++++++++++++++++++++
> 1 file changed, 164 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-ktd202x.yaml b/Documentation/devicetree/bindings/leds/leds-ktd202x.yaml
> new file mode 100644
> index 000000000000..9868d6f6f147
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-ktd202x.yaml

Filename matching compatible, so missing vendor prefix. Can be
kinetic,ktd202x.yaml

> @@ -0,0 +1,164 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/leds-ktd202x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Kinetic KTD2026/7 RGB/White LED Driver

Driver stands for Linux driver or for driving a LED? If the first, then
drop.


The rest looks good, so you just need to use proper filename.

Best regards,
Krzysztof