Re: [PATCH v4 5/6] arm64: dts: qcom: sm8550-mtp: add pmic glink port/endpoints

[Neil Armstrong]

On 19/06/2023 10:02, Krzysztof Kozlowski wrote:
> On 19/06/2023 09:58, Neil Armstrong wrote:
> > Add nodes to support Type-C USB/DP functionality.
> >
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > ---
>
> ...
>
> > +&i2c_hub_2 {
> > +	status = "okay";
> > +
> > +	typec-mux@42 {
> > +		compatible = "fcs,fsa4480";
> > +		reg = <0x42>;
> > +
> > +		vcc-supply = <&vreg_bob1>;
> > +
> > +		mode-switch;
> > +		orientation-switch;
> > +
> > +		ports {
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
>
> The node fsa4480 not take ports, but port according to bindings.

ack will respin a v5 with a single port.

Neil

> > +
> > +			port@0 {
> > +				reg = <0>;
> > +
> > +				fsa4480_sbu_mux: endpoint {
> > +					remote-endpoint = <&pmic_glink_sbu>;
> > +				};
> > +			};
>
>
>
> Best regards,
> Krzysztof