Re: [PATCH 1/1] vmgenid: emit uevent when VMGENID updates
From: Alexander Graf
Date: Mon Jun 19 2023 - 16:38:12 EST
Hey Jason,
On 19.06.23 22:30, Jason A. Donenfeld wrote:
Like the other patch, and as discussed before too, I don't think this
has any business being part of (virtual) hardware drivers, and instead
belongs in random.c, which might receive these notifications from a
variety of devices, and can thus synchronize things accordingly.
Please stop posting more of these same approaches. Same nack as the
other ones.
Could you please elaborate what other devices you envision emitting
"This VM was cloned, you MAC address may now collide" style events?
What we talked about at LPC was an orthogonal interface that allows user
space to receive reseed events when either the kernel, an RNG device or
anything else in the system wants to say "Your cached randomness may be
compromised, please fetch some new".
This patch is not that interface. It's an event meant for systemd (and
other system software) to know exclusively about VM clone events. That
system software can not use the reseed event above: Just imagine getting
a new MAC address every 5 minutes. So here we really just want to know
the vmgenid changed, no more, no less.
Alex
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879