Re: [PATCH v3 1/2] dt-bindings: net: motorcomm: Add pad driver strength cfg

From: Andrew Lunn
Date: Tue Jun 20 2023 - 10:00:21 EST


> I just got the detailed data of Driver Strength(DS) from Motorcomm ,
> which applies to both rx_clk and rx_data.
>
> |----------------------|
> | ds map table |
> |----------------------|
> | DS(3b) | Current (mA)|
> |--------|-------------|
> | 000 | 1.20 |
> | 001 | 2.10 |
> | 010 | 2.70 |
> | 011 | 2.91 |
> | 100 | 3.11 |
> | 101 | 3.60 |
> | 110 | 3.97 |
> | 111 | 4.35 |
> |--------|-------------|
>
> Since these currents are not integer values

Integers is not a problem. Simply use uA.

> and have no regularity, it is not very good to use in the drive/dts
> in my opinion.

I think they are fine to use. Add a lookup table, microamps to
register value. Return -EINVAL if the requested value is not in the
table. List the valid values in the schema, so the checker tool might
point out problems.

Andrew