Re: [PATCH net-next v1 12/14] net: phy: nxp-c45-tja11xx: read ext trig ts TJA1120

[Radu Pirea (OSS)]

On 19.06.2023 13:48, Horatiu Vultur wrote:
> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button
>
>
> The 06/19/2023 13:07, Radu Pirea (OSS) wrote:
> > On 19.06.2023 11:49, Horatiu Vultur wrote:
> > > The data->get_extts can't be null. So I don't think you need this check.
> >
> > I kinda agree with this because _I wrote the driver and I know what it
> > does_, but on the other hand don't want to fight with any static analyzer.
>
> Yes, but then wouldn't be an issue with the static analyzer tools that
> can't detect this kind of code?

You are right. I will remove the checks. They are useless in the end. A 
check of private data will be introduced only if a future PHY needs it.

Thank you.

> > > --
> > > /Horatiu
> >
> > --
> > Radu P.
>
> --
> /Horatiu

--
Radu P.