Re: [PATCH] counter: Fix menuconfig "Counter support" submenu entries disappearance

[Randy Dunlap]

Hi,

On 6/20/23 10:01, William Breathitt Gray wrote:
> The current placement of the I8254 Kconfig entry results in the
> disappearance of the "Counter support" submenu items in menuconfig. Move
> the I8254 above the menuconfig COUNTER entry to restore the intended
> submenu behavior.
> 
> Fixes: d428487471ba ("counter: i8254: Introduce the Intel 8254 interface library module")
> Reported-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
> Closes: https://lore.kernel.org/all/32ddaa7b-53a8-d61f-d526-b545bd561337@xxxxxxxxxxxxxxx/
> Signed-off-by: William Breathitt Gray <william.gray@xxxxxxxxxx>

Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

but why is I8254 here at all? Users cannot enable it
and nothing selects it.  Is it a WIP?

Thanks.

> ---
>  drivers/counter/Kconfig | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> index a61a4b9b8ec6..86536c2cc531 100644
> --- a/drivers/counter/Kconfig
> +++ b/drivers/counter/Kconfig
> @@ -3,13 +3,6 @@
>  # Counter devices
>  #
>  
> -menuconfig COUNTER
> -	tristate "Counter support"
> -	help
> -	  This enables counter device support through the Generic Counter
> -	  interface. You only need to enable this, if you also want to enable
> -	  one or more of the counter device drivers below.
> -
>  config I8254
>  	tristate
>  	select COUNTER
> @@ -25,6 +18,13 @@ config I8254
>  
>  	  If built as a module its name will be i8254.
>  
> +menuconfig COUNTER
> +	tristate "Counter support"
> +	help
> +	  This enables counter device support through the Generic Counter
> +	  interface. You only need to enable this, if you also want to enable
> +	  one or more of the counter device drivers below.
> +
>  if COUNTER
>  
>  config 104_QUAD_8
> 
> base-commit: d428487471ba6640ee8bcdabaf830aec08b85400

-- 
~Randy