Re: [PATCH 1/1] ASoC: codecs: max98090: Allow dsp_a mode

[Maxim Kochetkov]

On 21.06.2023 16:18, Mark Brown wrote:
> On Wed, Jun 21, 2023 at 04:02:34PM +0300, Maxim Kochetkov wrote:
> > On 21.06.2023 15:26, Mark Brown wrote:
>
> > > This is configuring DSP A identically to left justified mode, it looks
> > > like the format configuration needs at least some interlock with the TDM
> > > configuration.
>
> > According to datasheet MAX98090 supports only DSP_A (L data MSB after FRM
> > LRC) TDM mode. Allowing this mode will let us proper configure CPU audio
> > node via DT. Actual TDM mode activation is performed in
> > max98090_set_tdm_slot() via M98090_REG_TDM_FORMAT/M98090_REG_TDM_CONTROL
> > registers.
>
> I'm saying there should be some interlock between these two settings, if
> nothing else setting DSP A mode should force TDM mode with automatically
> configured slot sizes.

At this time there is no any interlock for TDM mode in MAX98090 driver. 
We can specify dai-tdm-slot-* properties in DT and .set_tdm_slot() will 
be called to setup TDM mode. And SND_SOC_DAIFMT cannot affect it. I 
checked other codecs drivers: most of them performs TDM setup this way. 
So why do we need such interlock right now?