Re: [PATCH v10 07/11] drm/etnaviv: Add support for the dma coherent device

[Sui Jingfeng]

Hi

On 2023/6/21 18:00, Lucas Stach wrote:
> > +	case ETNA_BO_CACHED:
> > +		prot = PAGE_KERNEL;
> > +		break;
> > +	case ETNA_BO_UNCACHED:
> > +		prot = pgprot_noncached(PAGE_KERNEL);
> > +		break;
> > +	case ETNA_BO_WC:
> > +	default:
> > +		prot = pgprot_writecombine(PAGE_KERNEL);
> > +	}
> > +
> > +	return vmap(pages, obj->base.size >> PAGE_SHIFT, VM_MAP, prot);
> While that change makes sense it should also be in a separate patch, as
> it's a valid change on its own, even if for non-coherent devices.
Accept with pleasure.

I will prepare the patch carefully.

Thanks for the positive comments.


--
Jingfeng