Re: [net-next PATCH v5 2/3] leds: trigger: netdev: add additional specific link duplex mode

[Lee Jones]

On Mon, 19 Jun 2023, Christian Marangi wrote:

> Add additional modes for specific link duplex. Use ethtool APIs to get the
> current link duplex and enable the LED accordingly. Under netdev event
> handler the rtnl lock is already held and is not needed to be set to
> access ethtool APIs.
> 
> This is especially useful for PHY and Switch that supports LEDs hw
> control for specific link duplex.
> 
> Add additional modes:
> - half_duplex: Turn on LED when link is half duplex
> - full_duplex: Turn on LED when link is full duplex
> 
> Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
> ---
>  drivers/leds/trigger/ledtrig-netdev.c | 27 +++++++++++++++++++++++++--
>  include/linux/leds.h                  |  2 ++
>  2 files changed, 27 insertions(+), 2 deletions(-)

Acked-by: Lee Jones <lee@xxxxxxxxxx>

-- 
Lee Jones [李琼斯]