Re: [PATCH v2 2/2] clk: nuvoton: Use clk_parent_data instead of string for parent clock

[Jacky Huang]

On 2023/6/21 下午 08:51, Greg KH wrote:
> On Wed, Jun 21, 2023 at 03:16:05AM +0000, Jacky Huang wrote:
> >   
> > -	hws[AXICLK_MUX] = ma35d1_clk_mux(dev, "axiclk_mux", clk_base + REG_CLK_CLKDIV0,
> > -					 26, 1, axiclk_sel_clks,
> > -					 ARRAY_SIZE(axiclk_sel_clks));
> > -	hws[SYSCLK0_MUX] = ma35d1_clk_mux(dev, "sysclk0_mux", clk_base + REG_CLK_CLKSEL0,
> > -					  2, 1, sysclk0_sel_clks,
> > -					  ARRAY_SIZE(sysclk0_sel_clks));
> > -	hws[SYSCLK1_MUX] = ma35d1_clk_mux(dev, "sysclk1_mux", clk_base + REG_CLK_CLKSEL0,
> > -					  4, 1, sysclk1_sel_clks,
> > -					  ARRAY_SIZE(sysclk1_sel_clks));
> > +	hws[AXICLK_MUX] = ma35d1_clk_mux(dev, "axiclk_mux", clk_base + REG_CLK_CLKDIV0, 26, 1,
> > +					 axiclk_sel_clks, ARRAY_SIZE(axiclk_sel_clks));
> > +
> > +	hws[SYSCLK0_MUX] = ma35d1_clk_mux(dev, "sysclk0_mux",
> > +					  clk_base + REG_CLK_CLKSEL0, 2, 1,
> > +					  sysclk0_sel_clks, ARRAY_SIZE(sysclk0_sel_clks));
> > +
> > +	hws[SYSCLK1_MUX] = ma35d1_clk_mux(dev, "sysclk1_mux", clk_base + REG_CLK_CLKSEL0, 4, 1,
> > +					  sysclk1_sel_clks, ARRAY_SIZE(sysclk1_sel_clks));
> > +
> No need to reformat lines that are not actually changing anything, as
> this makes the patch harder to review for real changes in it :(
>
> thanks,
>
> greg k-h


Dear Greg.


Thanks for your advice.

I will modify the patch again to remove these irrelevant parts that have 
no practical effect.


Best Regards,

Jacky Huang