Re: [PATCH v6 20/27] cxl/pci: Add RCH downstream port AER register discovery

From: Jonathan Cameron
Date: Thu Jun 22 2023 - 09:18:05 EST



>
> diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c
> index cfae8307de90..37ecd756b224 100644
> --- a/drivers/cxl/core/port.c
> +++ b/drivers/cxl/core/port.c
> @@ -678,7 +678,6 @@ static struct cxl_port *cxl_port_alloc(struct device *uport_dev,
> device_set_pm_not_required(dev);
> dev->bus = &cxl_bus_type;
> dev->type = &cxl_port_type;
> -

:(

I can't see any argument that removing the blank line is an improvement.

> return port;
>
> err:
> @@ -974,6 +973,8 @@ __devm_cxl_add_dport(struct cxl_port *port, struct device *dport_dev,
> return ERR_PTR(-ENOMEM);
>
> if (rcrb != CXL_RESOURCE_NONE) {
> + struct pci_host_bridge *host_bridge;
> +