Re: [PATCH v4 1/5] gpio: gxp: Add HPE GXP GPIO

[Andy Shevchenko]

On Thu, Jun 22, 2023 at 12:35 AM <nick.hawkins@xxxxxxx> wrote:
>
> From: Nick Hawkins <nick.hawkins@xxxxxxx>
>
> The GXP SoC supports GPIO on multiple interfaces. The interfaces are
> CPLD and Host. The GPIOs is a combination of both physical and virtual

GPIOs are

> I/O across the interfaces. The gpio-gxp driver specifically covers the
> CSM(physical), FN2(virtual), and VUHC(virtual) which are the host. The

"...are the host"?! hosts?

> driver supports interrupts from the host.

I will have some comments against the code, but I will try to review
it probably later on (next week or so). Taking into account the
approaching release date, I think we have a couple more months for
polishing this series.

--
With Best Regards,
Andy Shevchenko