Re: [PATCH] cachefiles: allocate static minor for /dev/cachefiles

[Greg KH]

On Thu, Jun 22, 2023 at 02:42:54PM +0100, David Howells wrote:
> Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
> 
> > The cachefiles misc character device uses MISC_DYNAMIC_MINOR and thus
> > doesn't support module auto-loading. Assign a static minor number for it
> > and provide appropriate module aliases for it. This is enough for kmod to
> > create the /dev/cachefiles device node on startup and facility module
> > auto-loading.
> 
> Why?  The systemd unit file for it just modprobe's the module first.  It's a
> specialist device file only for use by the appropriate daemon.

And you really don't want to have auto-module-loading when trying to
open a /dev/foo file, that way lies madness in the past, please let's
learn from our mistakes :)

thanks,

greg k-h