RE: [PATCH 00/12] New Crypto service commands

[Ang, Tien Sung]

> -----Original Message-----
> From: Dinh Nguyen <dinguyen@xxxxxxxxxx>
> Sent: Friday, 23 June, 2023 1:37 PM
> To: Ang, Tien Sung <tien.sung.ang@xxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 00/12] New Crypto service commands
> 
> 
> 
> On 6/22/23 22:20, tien.sung.ang@xxxxxxxxx wrote:
> > From: Ang Tien Sung <tien.sung.ang@xxxxxxxxx>
> >
> > hi,
> > This patch set comprises updates to the svc driver to add new crypto
> > services for AES encryption/decryption, SHA2 digest generation, SHA2
> > MAC verification, ECDSA hash signing, ECDSA SHA2 data signing, ECDSA
> > hash signature verification, ECDSA SHA2 data signature verification
> > crypto key management and lastly ECDSA public key retrieval.
> > The additions of the commands are all standard entries to svc driver
> > with minimal logic.
> >
> 
> I guess I'll ask the same question, who's the consumer for these?
> 
> 
This commands will be used by the future and current
downstream crypto driver that is under redesign.
The svc driver is merely a firmware messenger that is
used to send Mailbox commands to the SDM firmware. 
It is essential for us to begin doing this first. Thanks

> > Ang Tien Sung (12):
> >    firmware: stratix10-svc: support open & close crypto session
> >    firmware: stratix10-svc: crypto key management
> >    firmware: stratix10-svc: AES encrypt and decrypt
> >    firmware: stratix10-svc: increase msg arg size
> >    firmware: stratix10-svc: SHA-2 digest
> >    firmware: stratix10-svc: HMAC SHA2 verify
> >    firmware: stratix10-svc: ECDSA Hash signing
> >    firmware: stratix10-svc: ECDSA SHA2 data signing
> >    firmware: stratix10-svc: hash signature verification
> >    firmware: stratix10-svc: SHA2 signature verification
> >    firmware: stratix10-svc: public key request
> >    firmware: stratix10-svc: ECDH request
> >
> >   drivers/firmware/stratix10-svc.c              | 309 +++++++-
> >   include/linux/firmware/intel/stratix10-smc.h  | 708 ++++++++++++++++++
> >   .../firmware/intel/stratix10-svc-client.h     |  86 ++-
> >   3 files changed, 1100 insertions(+), 3 deletions(-)
> >