Re: [PATCH 09/15] arm64: dts: qcom: sc7280-crd: add dummy Bluetooth VDDIO supply

[Krzysztof Kozlowski]

On 23/06/2023 20:34, Doug Anderson wrote:
> Hi,
> 
> On Mon, Jun 19, 2023 at 6:14 AM Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:
>>
>> On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
>>> Bluetooth requires VDDIO supply.  Due to lack of schematics provide
>>> something dummy to satisfy `dtbs_check`:
>>>
>>>   sc7280-crd-r3.dtb: bluetooth: 'vddio-supply' is a required property
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>>> ---
>> For this:
>>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
>>
>> +CC Doug to perhaps fix this properly (though I think we should have got
>> it through the cros list anyway)
>>
>> Konrad
>>>  arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 11 +++++++++++
>>>  1 file changed, 11 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
>>> index afae7f46b050..b1aa5b0ee95c 100644
>>> --- a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
>>> +++ b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
>>> @@ -24,6 +24,13 @@ aliases {
>>>       chosen {
>>>               stdout-path = "serial0:115200n8";
>>>       };
>>> +
>>> +     bt_vddio: regulator-bt-vddio {
>>> +             compatible = "regulator-fixed";
>>> +             regulator-name = "bt-vddio";
>>> +             regulator-min-microvolt = <1800000>;
>>> +             regulator-max-microvolt = <1800000>;
>>> +     };
>>>  };
>>>
>>>  &apps_rsc {
>>> @@ -38,6 +45,10 @@ vreg_s1k_1p0: smps1 {
>>>       };
>>>  };
>>>
>>> +&bluetooth {
>>> +     vddio-supply = <&bt_vddio>;
>>> +};
>>> +
> 
> I would have a hard time believing that the more correct fix wouldn't be:
> 
> vddio-supply = <&vreg_l18b_1p8>;
> 
> Specifically L18B is what we have on the newer CRD (the one that is
> considered a "herobrine" and includes Qcard) and also IDP2. In terms
> of timeline / similarities, CRD-rev3 falls in between IDP2 and newer
> CRD. These both agree on L18B. The only board that uses something
> different (L19B) is the very old IDP1.
> 
> That being said, Qualcomm has never provided (at least to me)
> schematics for any given reference board. Whenever asked, I was always
> pointed at schematics that were said to be "close enough". Thus, I
> can't really give a definitive answer here. Even so, pointing at L18B
> seems to me to be 99% likely to be correct.

99% is good enough for me. Thanks, I will send a v2 after the merge window.

Best regards,
Krzysztof