Re: [PATCH] spi: dt-bindings: atmel,at91rm9200-spi: fix broken sam9x7 compatible

[Conor Dooley]

On Sat, Jun 24, 2023 at 10:20:54AM +0200, Krzysztof Kozlowski wrote:
> Commit a3eb95484f27 ("spi: dt-bindings: atmel,at91rm9200-spi: add sam9x7
> compatible") adding sam9x7 compatible did not make any sense as it added
> new compatible into middle of existing compatible list.  The intention
> was probably to add new set of compatibles with sam9x7 as first one.
> 
> Fixes: a3eb95484f27 ("spi: dt-bindings: atmel,at91rm9200-spi: add sam9x7 compatible")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

@Varshini, this is the template to follow for the rest of the series. I
know there's a lot of complaints while running dtbs_check for the entire
directory, but you can isolate things to a singular binding and check
the dts against it using:
make dtbs_check DT_SCHEMA_FILES=atmel,at91rm9200-spi.yaml
That should make it easier to see that you don't break existing dts by
modifying the binding.

Cheers,
Conor.

> ---
>  .../devicetree/bindings/spi/atmel,at91rm9200-spi.yaml          | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
> index bdc42eeacba4..58367587bfbc 100644
> --- a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
> @@ -19,7 +19,10 @@ properties:
>        - const: atmel,at91rm9200-spi
>        - items:
>            - const: microchip,sam9x60-spi
> +          - const: atmel,at91rm9200-spi
> +      - items:
>            - const: microchip,sam9x7-spi
> +          - const: microchip,sam9x60-spi
>            - const: atmel,at91rm9200-spi
>  
>    reg:
> -- 
> 2.34.1
>

Attachment: signature.asc
Description: PGP signature