Re: [PATCH] bus: ixp4xx: fix IXP4XX_EXP_T1_MASK

[Linus Walleij]

On Sat, Jun 24, 2023 at 1:30 PM Jonas Gorski <jonas.gorski@xxxxxxxxx> wrote:

> The IXP4XX_EXP_T1_MASK was shifted one bit to the right, overlapping
> IXP4XX_EXP_T2_MASK and leaving bit 29 unused. The offset being wrong is
> also confirmed at least by the datasheet of IXP45X/46X [1].
>
> Fix this by aligning it to IXP4XX_EXP_T1_SHIFT.
>
> [1] https://www.intel.com/content/dam/www/public/us/en/documents/manuals/ixp45x-ixp46x-developers-manual.pdf
>
> Fixes: 1c953bda90ca ("bus: ixp4xx: Add a driver for IXP4xx expansion bus")
> Signed-off-by: Jonas Gorski <jonas.gorski@xxxxxxxxx>

Yups that's a bug! (My typo...)

I'll funnel it upstream through the SoC tree.

Yours,
Linus Walleij