Re: [RFT PATCH] arm64: dts: qcom: sdm850-c630: add missing panel supply

[Caleb Connolly]

On 17/06/2023 17:15, Krzysztof Kozlowski wrote:
> Panel bindings (boe,nv133fhm-n61) require supply which here actually can
> be turned on/off via GPIO control:
> 
>   sdm850-lenovo-yoga-c630.dtb: panel: 'power-supply' is a required property
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

I've been running an equivalent patch for a while, so

Tested-by: Caleb Connolly <caleb.connolly@xxxxxxxxxx>

The dsi bridge vcc and vcca supplies are also missing, they're powered
from vreg_l2a_1p2 and controlled by pm8998_gpio 9.
> 
> ---
> 
> Not tested on hardware
> ---
>  .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> index cfbc4fc1eba9..3d871567cf81 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> @@ -87,6 +87,25 @@ sn65dsi86_refclk: sn65dsi86-refclk {
>  		clock-frequency = <19200000>;
>  	};
>  
> +	vph_pwr: regulator-vph-pwr {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vph_pwr";
> +		regulator-min-microvolt = <3700000>;
> +		regulator-max-microvolt = <3700000>;
> +	};
> +
> +	vlcm_3v3: regulator-vlcm-3v3 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vlcm_3v3";
> +
> +		vin-supply = <&vph_pwr>;
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +
> +		gpio = <&tlmm 88 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +	};
> +
>  	backlight: backlight {
>  		compatible = "pwm-backlight";
>  		pwms = <&sn65dsi86 1000000>;
> @@ -419,6 +438,7 @@ aux-bus {
>  			panel: panel {
>  				compatible = "boe,nv133fhm-n61";
>  				backlight = <&backlight>;
> +				power-supply = <&vlcm_3v3>;
>  
>  				port {
>  					panel_in_edp: endpoint {

-- 
// Caleb (they/them)