Re: Fwd: After kernel 6.3.7 or 6.3.8 b43 driver fails

From: Arnd Bergmann
Date: Sat Jun 24 2023 - 17:33:26 EST


On Sat, Jun 24, 2023, at 03:44, Bagas Sanjaya wrote:
> I notice a regression report on Bugzilla [1]. Quoting from it:
>
>> After upgrading to linux 6.3.8-arch1-1 from 6.3.6-arch1-1, b43 broadcom wireless driver fails. downgrading back to 6.3.6-arch1-1 resolves.
>>
>> Jun 16 20:56:37 askasleikir kernel: Hardware name: Apple Inc. MacBookPro7,1/Mac-F222BEC8, BIOS MBP71.88Z.0039.B15.1702241313 02/24/17
>> Jun 16 20:56:37 askasleikir kernel: Workqueue: phy0 b43_tx_work [b43]
>> Jun 16 20:56:37 askasleikir kernel: RIP: 0010:__ieee80211_stop_queue+0xcc/0xe0 [mac80211]

FWIW, the report is missing a few lines at the top about
which error condition is being hit.

>> Jun 16 20:56:37 askasleikir kernel: <TASK>
>> Jun 16 20:56:37 askasleikir kernel: ? __ieee80211_stop_queue+0xcc/0xe0 [mac80211 136d1d948548ad6cca697df0da0a13c0a2333310]
>> Jun 16 20:56:37 askasleikir kernel: ? __warn+0x81/0x130
>> Jun 16 20:56:37 askasleikir kernel: ? __ieee80211_stop_queue+0xcc/0xe0 [mac80211 136d1d948548ad6cca697df0da0a13c0a2333310]
>> Jun 16 20:56:37 askasleikir kernel: ? report_bug+0x171/0x1a0
>> Jun 16 20:56:37 askasleikir kernel: ? handle_bug+0x3c/0x80
>> Jun 16 20:56:37 askasleikir kernel: ? exc_invalid_op+0x17/0x70
>> Jun 16 20:56:37 askasleikir kernel: ? asm_exc_invalid_op+0x1a/0x20
>> Jun 16 20:56:37 askasleikir kernel: ? __ieee80211_stop_queue+0xcc/0xe0 [mac80211 136d1d948548ad6cca697df0da0a13c0a2333310]
>> Jun 16 20:56:37 askasleikir kernel: ieee80211_stop_queue+0x36/0x50 [mac80211 136d1d948548ad6cca697df0da0a13c0a2333310]

This indicates that a WARN_ON() was hit in __ieee80211_stop_queue(),
and the only condition that could cause this is

if (WARN_ON(queue >= hw->queues))
return;

Maybe that helps figure out what went wrong.

Arnd