Re: [PATCH 1/2] perf test: Reorder event name checks in stat STD output linter

[Namhyung Kim]

On Fri, Jun 23, 2023 at 4:22 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> On Fri, Jun 23, 2023 at 4:01 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> >
> > On AMD machines, the perf stat STD output test failed like below:
> >
> >   $ sudo ./perf test -v 98
> >    98: perf stat STD output linter                                     :
> >   --- start ---
> >   test child forked, pid 1841901
> >   Checking STD output: no argswrong event metric.
> >     expected 'GHz' in 108,121 stalled-cycles-frontend  # 10.88% frontend cycles idle
> >   test child finished with -1
> >   ---- end ----
> >   perf stat STD output linter: FAILED!
> >
> > This is because there are stalled-cycles-{frontend,backend} events are
> > used by default.  The current logic checks the event_name array to find
> > which event it's running.  But 'cycles' event comes before those stalled
> > cycles event and it matches first.  So it tries to find 'GHz' metric
> > in the output (which is for the 'cycles') and fails.
> >
> > Move the stalled-cycles-{frontend,backend} events before 'cycles' so
> > that it can find the stalled cycles events first.
> >
> > Also add a space after 'no args' test name for consistency.
> >
> > Fixes: 99a04a48f225 ("perf test: Add test case for the standard 'perf stat' output")
> > Cc: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
> > Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
>
> Acked-by: Ian Rogers <irogers@xxxxxxxxxx>

Applied both to perf-tools-next, thanks!