Re: [PATCH 1/4] sh: fix -Wmissing-include-dirs warnings for various platforms

[John Paul Adrian Glaubitz]

> On Jun 25, 2023, at 9:57 AM, Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
> 
> On Sun, Feb 19, 2023 at 11:40 PM John Paul Adrian Glaubitz
> <glaubitz@xxxxxxxxxxxxxxxxxxx> wrote:
>> 
>> Hi Masahiro!
>> 
>>> On Sun, 2023-02-19 at 23:15 +0900, Masahiro Yamada wrote:
>>> The 0day bot reports a lot of warnings (or errors due to CONFIG_WERROR)
>>> like this:
>>> 
>>>  cc1: error: arch/sh/include/mach-hp6xx: No such file or directory [-Werror=missing-include-dirs]
>>> 
>>> Indeed, arch/sh/include/mach-hp6xx does not exist.
>>> 
>>> -Wmissing-include-dirs is W=1 warning, but it may be annoying
>>> when CONFIG_BTRFS_FS is enabled because fs/btrfs/Makefile
>>> unconditionally adds this warning option.
>>> 
>>> arch/sh/Makefile defines machdir-y for two purposes:
>>> 
>>> - Build platform code in arch/sh/boards/mach-*/
>>> - Add arch/sh/include/mach-*/ to the header search path
>>> 
>>> For the latter, some platforms use arch/sh/include/mach-common/ instead
>>> of having its own arch/sh/include/mach-*/.
>>> 
>>> Drop unneeded machdir-y to not include non-existing include directory.
>>> 
>>> To build arch/sh/boards/mach-*/, use the standard obj-y syntax in
>>> arch/sh/boards/Makefile.
>>> 
>>> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>>> Link: https://lore.kernel.org/oe-kbuild-all/202302190641.30VVXnPb-lkp@xxxxxxxxx/
>>> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
>>> ---
>> 
>> Thanks for your patches! I'm still waiting for my kernel.org account to be created,
>> so I can set up my own linux-sh tree. I hope that happens next week. There are already
>> some patches piling up.
> 
> 
> So, what has happened since then?

Sorry, these somehow went off my radar.

I’ll have a look later today.

Adrian