Re: [PATCH 4/4] arm64: dts: imx93: enable CM33 for 11x11 EVK

From: Krzysztof Kozlowski
Date: Sun Jun 25 2023 - 07:21:42 EST


On 25/06/2023 12:55, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@xxxxxxx>
>
> Add reserved memory node for rpmsg
> Enable CM33 node with mailbox property included for doorbell.
>
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>

...

> };
>
> reg_vref_1v8: regulator-adc-vref {
> @@ -107,6 +139,16 @@ &lpuart1 { /* console */
> status = "okay";
> };
>
> +&{/remoteproc-cm33} {

That's not proper reference by label.

> + mbox-names = "tx", "rx", "rxdb";
> + mboxes = <&mu1 0 1
> + &mu1 1 1
> + &mu1 3 1>;

Three entries, not one. Anyway, why mboxes depend on the board? This is
quite surprising.

Best regards,
Krzysztof